Skip to content

Hotfix: restrict OrdinaryDiffEqCore to fix CI#2775

Merged
ranocha merged 4 commits intomainfrom
ranocha-patch-2
Feb 4, 2026
Merged

Hotfix: restrict OrdinaryDiffEqCore to fix CI#2775
ranocha merged 4 commits intomainfrom
ranocha-patch-2

Conversation

@ranocha
Copy link
Copy Markdown
Member

@ranocha ranocha commented Feb 4, 2026 •
edited
Loading

SciML/OrdinaryDiffEq.jl#3011 introduced a circular dependency in OrdinaryDiffEqCore.jl that lets our CI fail completely. The offending PR has been included in release v3.3.0 of OrdinaryDiffEqCore.jl. @JoshuaLampert has been working on several hotfix options within OrdinaryDiffEq.jl, but none of them had been accepted, see

To enable working on Trixi.jl, I introduced a hotfix, excluding the broken versions of OrdinaryDiffEqCore.jl.

By the way, you can also see the errors in the CI runs of OrdinaryDiffEq.jl, e.g.,

@ranocha ranocha requested a review from JoshuaLampert February 4, 2026 06:27
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 4, 2026

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@ranocha ranocha mentioned this pull request Feb 4, 2026
Closed
@ranocha ranocha added the bug Something isn't working label Feb 4, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 4, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.03%. Comparing base (ead0db3) to head (6c5cd84).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2775   +/-   ##
=======================================
  Coverage   97.03%   97.03%           
=======================================
  Files         569      569           
  Lines       44642    44642           
=======================================
  Hits        43318    43318           
  Misses       1324     1324
Flag Coverage Δ
unittests 97.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

JoshuaLampert
JoshuaLampert previously approved these changes Feb 4, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to avoid this step, but it seems we need to go it... To fix downstream tests, we would need to add OrdinaryDiffCore.jl as extra (test) dependency in TrixiShallowWater.jl and TrixiAtmo.jl to be able to restrict it. Not sure, why the downstream TrixiAtmo.jl test is not failing. In the logs, there is an error. Could you prepare these PRs?

@ranocha
Copy link
Copy Markdown
Member Author

ranocha commented Feb 4, 2026 •
edited
Loading

I added OrdinaryDiffEqCore.jl as a direct dependency here to fix downstream tests. Then, we only have to change one place when the upstream issue has been fixed.

JoshuaLampert
JoshuaLampert previously approved these changes Feb 4, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added OrdinaryDiffEqCore.jl as a direct dependency to fix downstream tests.

Yeah, that's also a solution. Thanks!

@ranocha ranocha enabled auto-merge (squash) February 4, 2026 07:17
@ranocha ranocha mentioned this pull request Feb 4, 2026
Merged
@ranocha ranocha merged commit a5d839f into main Feb 4, 2026
40 checks passed
@ranocha ranocha deleted the ranocha-patch-2 branch February 4, 2026 08:19
@JoshuaLampert JoshuaLampert mentioned this pull request Feb 4, 2026
Merged
DanielDoehring pushed a commit to DanielDoehring/Trixi.jl that referenced this pull request Feb 19, 2026
@ranocha @DanielDoehring
Hotfix: restrict OrdinaryDiffEqCore to fix CI (trixi-framework#2775)
0609ed9 
* Hotfix: restrict OrdinaryDiffEqCore to fix CI

* Fix formatting of OrdinaryDiffEqCore version range

* hotfix OrdinaryDiffEqCore.jl as direct dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshuaLampert JoshuaLampert JoshuaLampert approved these changes

Assignees

No one assigned

Labels

bug Something isn't working testing upstream

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ranocha @JoshuaLampert